[Windows] Add support for php.new and scoop

[Kocal]

I'm currently working on Windows to ensure a fix on Symfony UX, I downloaded PHP through php.new, manually from https://windows.php.net/ extracted in C:, and through scoop install main/php, but neither of these solutions are supported: https://github.com/symfony-cli/phpstore/blob/main/discovery_windows.go#L29-L53

For reference:

• php.new installs PHP at <disk>:\Users\.config/herd-lite/bin/php
• scoop install PHP at <disk>:\Users\<user>\scoop\apps\php (multiple versions can be installed I think)

[tucksaun]

IIRC scoop installs shims in the PATH.
Can you run symfony local:php:list -vvv so that we can check the debug output?

[tucksaun]

manually from https://windows.php.net/ extracted in C:

this should work if php.exe is in your PATH

[Kocal]

IIRC scoop installs shims in the PATH. Can you run symfony local:php:list -vvv so that we can check the debug output?

PS C:\Users\L\Projects> symfony local:php:list -vvv
8:33AM DBG Looking for PHP in C:\xampp\php (<nil>) -- XAMPP
8:33AM DBG Looking for PHP in C:\cygwin64\bin (<nil>) -- Cygwin
8:33AM DBG Looking for PHP in C:\cygwin\bin (<nil>) -- Cygwin
8:33AM DBG Looking for PHP in the PATH ([C:\Windows\System32 C:\Windows C:\Windows\System32\wbem C:\Windows\System32\WindowsPowerShell\v1.0 C:\Windows\System32\OpenSSH C:\Program Files\Git\cmd C:\Program Files\Git\mingw64\bin C:\Program Files\Git\usr\bin C:\Program Files\GitHub CLI C:\Users\L\scoop\shims C:\Users\L\.config\herd-lite\bin C:\Users\L\AppData\Local\Microsoft\WindowsApps C:\Users\L\AppData\Local\Programs\VSCodium\bin])
8:33AM DBG Looking for PHP in C:\Windows\System32 (<nil>) -- PATH
8:33AM DBG Looking for PHP in C:\Windows (<nil>) -- PATH
8:33AM DBG Looking for PHP in C:\Windows\System32\wbem (<nil>) -- PATH
8:33AM DBG Looking for PHP in C:\Windows\System32\WindowsPowerShell\v1.0 (<nil>) -- PATH
8:33AM DBG Looking for PHP in C:\Windows\System32\OpenSSH (<nil>) -- PATH
8:33AM DBG Looking for PHP in C:\Program Files\Git\cmd (<nil>) -- PATH
8:33AM DBG Looking for PHP in C:\Program Files\Git\mingw64\bin (<nil>) -- PATH
8:33AM DBG Looking for PHP in C:\Program Files\Git\usr\bin (<nil>) -- PATH
8:33AM DBG Looking for PHP in C:\Program Files\GitHub CLI (<nil>) -- PATH
8:33AM DBG Looking for PHP in C:\Users\L\scoop\shims (<nil>) -- PATH
8:33AM DBG   Unable to run "C:\Users\L\scoop\shims\php.exe --version: exit status 1"
8:33AM DBG Looking for PHP in C:\Users\L\.config\herd-lite\bin (<nil>) -- PATH
8:33AM DBG Looking for PHP in C:\Users\L\AppData\Local\Microsoft\WindowsApps (<nil>) -- PATH
8:33AM DBG Looking for PHP in C:\Users\L\AppData\Local\Programs\VSCodium\bin (<nil>) -- PATH
+---------+-----------+---------+---------+---------+--------+---------+
| Version | Directory |   PHP   |   PHP   |   PHP   | Server | System? |
|         |           |   CLI   |   FPM   |   CGI   |        |         |
+---------+-----------+---------+---------+---------+--------+---------+
+---------+-----------+---------+---------+---------+--------+---------+


To control the version used in a directory, create a .php-version file that contains the version number (e.g. 8.4 or 8.4.8),
or define config.platform.php inside composer.json.
If you're using Platform.sh or Upsun, the version can also be specified in their configuration files.
PS C:\Users\L\Projects>

Indeed, it founds the php binary in scoop shims folder, but 8:33AM DBG Unable to run "C:\Users\L\scoop\shims\php.exe --version: exit status 1":

PS C:\Users\L\Projects> ..\scoop\shims\php -i
PHP Warning:  'C:\Windows\SYSTEM32\VCRUNTIME140.dll' 14.0 is not compatible with this PHP build linked with 14.44 in Unknown on line 0

My VM is pretty new, I will try to upgrade VCRUNTIME140.dll

[Kocal]

Updated the VCRUNTIME*.dll through https://learn.microsoft.com/fr-fr/cpp/windows/latest-supported-vc-redist?view=msvc-170#latest-microsoft-visual-c-redistributable-version, PHP installed with Scoop is now correctly detected:

PS C:\Users\L\Projects> symfony local:php:list -vvv
8:42AM DBG Looking for PHP in C:\xampp\php (<nil>) -- XAMPP
8:42AM DBG Looking for PHP in C:\cygwin64\bin (<nil>) -- Cygwin
8:42AM DBG Looking for PHP in C:\cygwin\bin (<nil>) -- Cygwin
8:42AM DBG Looking for PHP in the PATH ([C:\Windows\System32 C:\Windows C:\Windows\System32\wbem C:\Windows\System32\WindowsPowerShell\v1.0 C:\Windows\System32\OpenSSH C:\Program Files\Git\cmd C:\Program Files\Git\mingw64\bin C:\Program Files\Git\usr\bin C:\Program Files\GitHub CLI C:\Users\L\scoop\shims C:\Users\L\.config\herd-lite\bin C:\Users\L\AppData\Local\Microsoft\WindowsApps C:\Users\L\AppData\Local\Programs\VSCodium\bin])
8:42AM DBG Looking for PHP in C:\Windows\System32 (<nil>) -- PATH
8:42AM DBG Looking for PHP in C:\Windows (<nil>) -- PATH
8:42AM DBG Looking for PHP in C:\Windows\System32\wbem (<nil>) -- PATH
8:42AM DBG Looking for PHP in C:\Windows\System32\WindowsPowerShell\v1.0 (<nil>) -- PATH
8:42AM DBG Looking for PHP in C:\Windows\System32\OpenSSH (<nil>) -- PATH
8:42AM DBG Looking for PHP in C:\Program Files\Git\cmd (<nil>) -- PATH
8:42AM DBG Looking for PHP in C:\Program Files\Git\mingw64\bin (<nil>) -- PATH
8:42AM DBG Looking for PHP in C:\Program Files\Git\usr\bin (<nil>) -- PATH
8:42AM DBG Looking for PHP in C:\Program Files\GitHub CLI (<nil>) -- PATH
8:42AM DBG Looking for PHP in C:\Users\L\scoop\shims (<nil>) -- PATH
8:42AM DBG   Found PHP: C:\Users\L\scoop\shims\php.exe, with CGI: C:\Users\L\scoop\shims\php-cgi.exe, with phpdbg: C:\Users\L\scoop\shims\phpdbg.exe
8:42AM DBG   System PHP version (first in PATH)
8:42AM DBG Looking for PHP in C:\Users\L\.config\herd-lite\bin (<nil>) -- PATH
8:42AM DBG Looking for PHP in C:\Users\L\AppData\Local\Microsoft\WindowsApps (<nil>) -- PATH
8:42AM DBG Looking for PHP in C:\Users\L\AppData\Local\Programs\VSCodium\bin (<nil>) -- PATH
+---------+------------------------+---------+---------+-------------+---------+---------+
| Version |       Directory        |   PHP   |   PHP   |     PHP     | Server  | System? |
|         |                        |   CLI   |   FPM   |     CGI     |         |         |
+---------+------------------------+---------+---------+-------------+---------+---------+
| 8.4.9   | C:\Users\L\scoop\shims | php.exe |         | php-cgi.exe | PHP CGI | *       |
+---------+------------------------+---------+---------+-------------+---------+---------+

The current PHP version is selected from default version in $PATH

To control the version used in a directory, create a .php-version file that contains the version number (e.g. 8.4 or 8.4.8),
or define config.platform.php inside composer.json.
If you're using Platform.sh or Upsun, the version can also be specified in their configuration files.
PS C:\Users\L\Projects>

Thanks!

PS: I will see later to add support for php.new

[tucksaun]

Great 🎉

Yeah support for php.new install would be nice!
It's probably a matter of simple fix as the directory is detected from the PATH ("Looking for PHP in C:\Users\L.config\herd-lite\bin () -- PATH")