fix(core): create precision time protobuf#742
Merged
bestbeforetoday merged 1 commit intosubstrait-io:mainfrom Mar 10, 2026
Merged
fix(core): create precision time protobuf#742bestbeforetoday merged 1 commit intosubstrait-io:mainfrom
bestbeforetoday merged 1 commit intosubstrait-io:mainfrom
Conversation
The io.substrait.type.proto.TypeProtoConverter.Types#wrap(Object) method was missing a branch to handle PrecisionTime. This caused an UnsupportedOperationException to the be thrown when creating a PrecisionTime protobuf object. This change adds the missing branch to the wrap method, and extends type pojo/proto conversion tests to include PrecisionTime. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The io.substrait.type.proto.TypeProtoConverter.Types#wrap(Object) method was missing a branch to handle PrecisionTime. This caused an UnsupportedOperationException to the be thrown when creating a PrecisionTime protobuf object.
This change adds the missing branch to the wrap method, and extends type pojo/proto conversion tests to include PrecisionTime.