Skip to content

build: remove redundant examples build#741

Open
nielspardon wants to merge 1 commit intosubstrait-io:mainfrom
nielspardon:par-rm-examples-build
Open

build: remove redundant examples build#741
nielspardon wants to merge 1 commit intosubstrait-io:mainfrom
nielspardon:par-rm-examples-build

Conversation

@nielspardon
Copy link
Member

The Substrait Spark examples are already being included in the default Gradle build:

"examples:substrait-spark",

The additional examples build in Github Actions essentially also just runs the regular Gradle build besides creating a couple directories and copying files around:

# Builds the application into a JAR file
buildapp:
#!/bin/bash
set -e -o pipefail
${CWDIR}/../../gradlew build
# need to let the SPARK user be able to write to the _data mount
mkdir -p ${CWDIR}/_data && chmod g+w ${CWDIR}/_data
mkdir -p ${CWDIR}/_apps
cp ${CWDIR}/build/libs/substrait-spark*.jar ${CWDIR}/_apps/app.jar
cp ${CWDIR}/src/main/resources/*.csv ${CWDIR}/_data

I think we can remove the redundant examples build step from Github Actions and shorten the build time.

Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant