fix: minimise overflow on timestamp conversion#737
Open
bestbeforetoday wants to merge 1 commit intosubstrait-io:mainfrom
Open
fix: minimise overflow on timestamp conversion#737bestbeforetoday wants to merge 1 commit intosubstrait-io:mainfrom
bestbeforetoday wants to merge 1 commit intosubstrait-io:mainfrom
Conversation
When converting a Calcite timestamp to Substrait, we target microsecond precision. However, this is achieved by calculating entirely in nanoseconds and then narrowing to microseconds, introducing the possibility of overflow when dealing with timestamps beyond the year 2262. This change targets microseconds directly when converting Calcite timestamp literals. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
date-time-conversion
branch
from
3d5099d to
5c91214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting a Calcite timestamp to Substrait, we target microsecond precision. However, this is achieved by calculating entirely in nanoseconds and then narrowing to microseconds, introducing the possibility of overflow when dealing with timestamps beyond the year 2262.
This change targets microseconds directly when converting Calcite timestamp literals.