build: use antlr grammars directly from submodule#730
Draft
Conversation
Member
Author
|
Grrrr, this fails on a clean build and/or in CI 😒 |
vbarua
force-pushed
the
vbarua/antlr-from-submodule
branch
from
1065cd9 to
2f893fb
Compare
nielspardon
reviewed
Mar 9, 2026
nielspardon
reviewed
Mar 9, 2026
nielspardon
approved these changes
Mar 9, 2026
Member
nielspardon
left a comment
nielspardon
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge when you think it's ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid manual copying of Substrait grammars from submodule into core project