Added check for MSVS2013 as GetVersionEx is marked as depricated. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrpowers
added a commit
that referenced
this pull request
May 5, 2014
Added check for MSVS2013 as GetVersionEx is marked as depricated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to build this with visual studio 2013 express, but get a warning/error at the GetVersionEx.
I have implemented a new method to make use of the VersionHelpers, and a check if the VS is 1800 or above.
It seems that the xnOSGetInfo is not used at all, and I tried to use it in the NiViewer tool project, but I got some linking erros to InitializeSecurityDescriptor and SetSecurityDescriptorDacl which is part of the WINAPI.
Hence it is not checked for runtime errors.
Alternatively the xnOSGetInfo could just be removed?
Regards, Lars