Merged
Conversation
Implement method for registering (new) middleware phases.
- If all names are new, then the phases are added just before
the "routes" phase.
- Otherwise the provided list of names is merged with the existing
phases in such way that the order of phases is preserved.
Example
// built-in phases:
// initial, session, auth, parse, routes, files, final
app.defineMiddlewarePhases('custom');
// new list of phases
// initial, session, auth, parse,
// custom,
// routes, files, final
app.defineMiddlewarePhases([
'initial', 'postinit', 'preauth', 'routes', 'subapps'
]);
// new list of phases
// initial,
// postinit, preauth,
// session, auth, parse, custom,
// routes,
// subapps,
// files, final
bajtos
force-pushed
the
feature/define-middleware-phases
branch
from
877949e to
98d4390
Compare
Member
There was a problem hiding this comment.
Shouldn't this be in loopback-phase?
Member
There was a problem hiding this comment.
+1 to refactor the code to register phases by relative order to loopback-phase.
Member
Author
There was a problem hiding this comment.
Good point. I'll land this patch and submit the refactoring in a new PR.
Member
|
LGTM |
bajtos
added a commit
that referenced
this pull request
Nov 12, 2014
Implement `app.defineMiddlewarePhases`
This was referenced Nov 12, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement method for registering (new) middleware phases.
the "routes" phase.
phases in such way that the order of phases is preserved.
Example
A part of #739, requires strongloop/loopback-phase#5
/to @ritch please review
/cc @raymondfeng