Use the new API for defining remoting types#58
Merged
Conversation
This was referenced Sep 1, 2016
Member
Author
|
CI builds are failing because npm installs wrong version of strong-remoting. They should start passing once strongloop/strong-remoting#343 is landed. |
3 tasks
Member
I'm trying this PR with NPM link to your branch in strongloop/strong-remoting#343 and it gives me the following error: Could you please run npm test locally to see if you get the same failure? |
Member
Author
|
Will do. Note that the error is thrown by code in Circular dependencies are not fun :( |
f1cf3ae to
b82bd1a
Compare
b82bd1a to
bce9971
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up for strongloop/strong-remoting#343, which dropped
Dynamicand related APIs.@gunjpan please review
cc @richardpringle
Requires strongloop/strong-remoting#343
Connect to strongloop-internal/scrum-loopback#974
Connect to strongloop-internal/scrum-loopback#885
TODO before merging