Skip to content

[2.0] Configure models#9

Merged
bajtos merged 2 commits into2.0from
configure-models
Jun 10, 2014
Merged

[2.0] Configure models#9
bajtos merged 2 commits into2.0from
configure-models

Conversation

@bajtos
Copy link
Copy Markdown
Member

@bajtos bajtos commented Jun 9, 2014

  • Change models.json to configure existing models
  • Remove auto-attach

/to @ritch please review
/cc @kraman

Requires: strongloop/loopback#308
Related to: strongloop/loopback-example-offline-sync#13

Before this patch can be released to npm, we have to back-port loopback 304 & 308 to loopback 1.x (master) - see strongloop/loopback#321.

Before this patch is landed, we have to either back-port loopback 304 & 308 to loopback 1.x (master) or drop loopback 1.x from package.json of loopback-boot.

README.md Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what 2.5 is referring to. Are you suggesting we break backwards compatibility at loopback 2.5 or are you talking about workpasce 2.5?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.5 is the version of slc, I'll update the text.

@ritch
Copy link
Copy Markdown
Member

ritch commented Jun 9, 2014

LGTM

Miroslav Bajtoš added 2 commits June 10, 2014 09:21
Breaking change.

In the new 2.x project layout, definition of loopback Models is out of
scope of the boot process. The bootstrapper only configures existing
models - attaches them to a dataSource and the app object.
Breaking change.

The bootstrapper no longer calls `loopback.autoAttach`. Applications
have to explicitly configure datasources for their models
via `models.json`.
bajtos added a commit that referenced this pull request Jun 10, 2014
@bajtos bajtos merged commit fccc6e1 into 2.0 Jun 10, 2014
@bajtos bajtos changed the title Configure models [2.0] Configure models Jun 12, 2014
@raymondfeng raymondfeng deleted the configure-models branch November 18, 2014 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants