This repository was archived by the owner on May 29, 2019. It is now read-only.
Merged
Conversation
Mocha 1.19 introduced nested contexts, where each `describe` has its own context inheriting from parent's context via prototype. The helper `whenCalledRemotely` was reading `this.url` to allow users to override the url. However, since `whenCalledRemotely` was not clearing `this.url` properly at the end of the test, the override worked for the first request only. Subsequent requests used the same URL as provided in the helper parameters. This commit fixes the problem by changing `this.url = undefined` to `delete this.url`, so that the the sub-sequent calls can access `this.__proto__.url` in the same way as the first call.
bajtos
added a commit
that referenced
this pull request
Jun 9, 2014
helpers: fix usage of mocha contexts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mocha 1.19 introduced nested contexts, where each
describehas itsown context inheriting from parent's context via prototype.
The helper
whenCalledRemotelywas readingthis.urlto allowusers to override the url. However, since
whenCalledRemotelywasnot clearing
this.urlproperly at the end of the test, the overrideworked for the first request only. Subsequent requests used the same
URL as provided in the helper parameters.
This commit fixes the problem by changing
this.url = undefinedto
delete this.url, so that the the sub-sequent calls can accessthis.__proto__.urlin the same way as the first call./cc @ritch @raymondfeng FYI