Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
301fdeb to
c63a5b7
Compare
a20c95a to
97f084e
Compare
content/develop/concepts/custom-components/components-v2/mount.md
Outdated
Show resolved
Hide resolved
content/develop/concepts/custom-components/components-v2/theming.md
Outdated
Show resolved
Hide resolved
content/develop/concepts/custom-components/components-v2/theming.md
Outdated
Show resolved
Hide resolved
content/develop/concepts/custom-components/components-v2/package-based.md
Outdated
Show resolved
Hide resolved
| name="isolated", | ||
| html="<div class='my-style'>Isolated content</div>", | ||
| css=".my-style { color: red; }", # Won't affect other elements | ||
| isolate_styles=True # Default |
There was a problem hiding this comment.
issue: We moved isolate_styles to be a mount-time argument as of Streamlit 1.53.
There was a problem hiding this comment.
Omg wait, I had this backwards 😓 isolate_styles moved to a registration-time argument in 1.53. It was a mount-time argument before that. I'm sorry for the unnecessary back and forth on this one @sfc-gh-dmatthews !
content/develop/concepts/custom-components/components-v2/register.md
Outdated
Show resolved
Hide resolved
content/develop/concepts/custom-components/components-v2/register.md
Outdated
Show resolved
Hide resolved
content/develop/concepts/custom-components/components-v2/package-based.md
Show resolved
Hide resolved
content/develop/concepts/custom-components/components-v2/register.md
Outdated
Show resolved
Hide resolved
sfc-gh-bnisco
left a comment
There was a problem hiding this comment.
LGTM after fixing the last few things!
content/develop/concepts/custom-components/components-v2/theming.md
Outdated
Show resolved
Hide resolved
| name="isolated", | ||
| html="<div class='my-style'>Isolated content</div>", | ||
| css=".my-style { color: red; }", # Won't affect other elements | ||
| isolate_styles=True # Default |
There was a problem hiding this comment.
Omg wait, I had this backwards 😓 isolate_styles moved to a registration-time argument in 1.53. It was a mount-time argument before that. I'm sorry for the unnecessary back and forth on this one @sfc-gh-dmatthews !
03e30f9 to
b2e3629
Compare
8ce01f4 to
66d2635
Compare
b2e3629 to
7c7403f
Compare
Merge activity
|

📚 Context
The parent branch (
apps/custom-components-concepts) added example apps and the quickstart page for Custom Components v2. This branch adds the full conceptual documentation for CCV2, restructures the existing custom components section to accommodate both v1 and v2, and updates navigation accordingly.🧠 Description of Changes
_index.md), an Overview page comparing v1 vs v2, a dedicated Components v1 subsection, and a new Components v2 subsection.components-api.md,create-component.md,limitations.md) into acomponents-v1/directory with updated slugs, and created a v1 index page preserving the original content.publish-component.mdtopublish.md(shared across v1/v2).components-v2/:_index.md— v2 landing page with tile navigationregister.md— component registration (HTML/CSS/JS definition)mount.md— component mounting and output handlingcommunicate.md— bidirectional communicationstate-and-triggers.md— state values vs trigger valuestheming.md— theme integration and CSS custom propertiespackage-based.md— building distributable TS-based componentsexamples/— 8 quickstart example pages (hello world, rich data, simple button, simple checkbox, interactive counter, text input, danger button, radial menu)overview.md— a new top-level overview comparing v1 and v2 with a feature comparison table.component-communication-cycle.svgdiagram illustrating bidirectional data flow.content/menu.mdto reflect the new section hierarchy with all new pages in the sidebar nav.public/_redirectsto point legacy v1 URLs to their newcomponents-v1/paths.Current:
The Custom Components section has a flat structure with only v1 docs (Intro, Create, Publish, Limitations).
Revised:
The Custom Components section is now versioned with an Overview, a full Components v2 subsection (7 concept pages + 8 example pages), a Components v1 subsection, and a shared Publish page.
💥 Impact
Size:
🌐 References
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.