feat(Group): add add_ips_to_group and remove_ips_from_group#196
Merged
chao-peng-story merged 3 commits intomainfrom Feb 26, 2026
Merged
Conversation
Collaborator
chao-peng-story
commented
Feb 25, 2026
chao-peng-story
commented
- GroupingModule client: add removeIp and build_removeIp_transaction
- Group: add add_ips_to_group(group_ip_id, ip_ids, max_allowed_reward_share_percentage=100, tx_options)
- Group: add remove_ips_from_group(group_ip_id, ip_ids, tx_options)
- Unit tests for both methods (invalid args, success, default/zero reward share, tx failure)
- Integration tests: add_ips_to_group, remove_ips_from_group, add then remove
- GroupingModule client: add removeIp and build_removeIp_transaction - Group: add add_ips_to_group(group_ip_id, ip_ids, max_allowed_reward_share_percentage=100, tx_options) - Group: add remove_ips_from_group(group_ip_id, ip_ids, tx_options) - Unit tests for both methods (invalid args, success, default/zero reward share, tx failure) - Integration tests: add_ips_to_group, remove_ips_from_group, add then remove
chao-peng-story
requested review from
limengformal,
lucas2brh,
roycezhaoca and
yingyangxu2026
as code owners
chao-peng-story
temporarily deployed
to
aeneid
GitHub Actions
Inactive
- Group: return tx_receipt in add_ips_to_group/remove_ips_from_group; add get_added_ip_to_group_events and get_removed_ip_from_group_events for chain verification - Integration tests: verify on-chain state via AddedIpToGroup/RemovedIpFromGroup events and get_claimable_reward - transaction_utils: refactor build_and_send_transaction (extract helpers, retry on replacement underpriced/nonce too low with same nonce + higher gas); add nonce validation in encodedTxDataOnly path
chao-peng-story
temporarily deployed
to
aeneid
GitHub Actions
Inactive
- addIp: validate groupId/ipIds not disputed, ipIds not registered groups - DisputeModuleClient.isIpTagged, IPAssetRegistryClient.isRegisteredGroup - removeIp: validate group not frozen (no derivative IPs, no minted license tokens) - LicenseRegistryClient.hasDerivativeIps, LicenseTokenClient.getTotalTokensByLicensor - Add LicenseTokenClient and DisputeModuleClient to Group - Unit tests for new validations
lucas2brh
approved these changes
Feb 26, 2026
yingyangxu2026
approved these changes
Feb 26, 2026
chao-peng-story
deleted the
feature/add-ips-to-group-and-remove-ips-from-group
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.