This repository is currently being migrated. It's locked while the migration is in progress.
Handle partial results returned from a GetVolumes API call#229
Merged
Ricardo-Osorio merged 4 commits intomasterfrom Feb 27, 2023
Merged
Handle partial results returned from a GetVolumes API call#229Ricardo-Osorio merged 4 commits intomasterfrom
Ricardo-Osorio merged 4 commits intomasterfrom
Conversation
During the client.GetAllVolumes call we also fetch all namespaces so store this information in the volume config and later use it during the GetVolumes request. Doing so removes one api call from being made during the GetVolumes command.
Mojachieee
approved these changes
Feb 27, 2023
Ricardo-Osorio
added a commit
that referenced
this pull request
Feb 27, 2023
Handle the context deadline exceeded error from the backend (identified by the http status code PartialContent returned) and print the data we managed to get back This data set will most likely fail to include some of the data about volume replicas so for those volumes we may see 0/2 replicas healthy even thought they may exist and be healthy To make this clear for the user I have added a message that prints just before the table output that reads: `context deadline exceeded, these are partial results and may be missing replica states for some volumes` We expect this to be a rare case to hit
|
I've been experimenting with Ondat the last couple of weeks, but I've already hit this error message multiple times. This directly makes the CLI unusable to What's worse is that there is currently no way to resolve the issue. The faulty volumes / replica's are not visible in k8s and I can't use the cli to remove them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the context deadline exceeded error from the backend (identified by the http status code PartialContent returned) and print the data we managed to get back
This data set will most likely fail to include some of the data about volume replicas so for those volumes we may see 0/2 replicas healthy even thought they may exist and be healthy
To make this clear for the user I have added a message that prints just before the table output that reads:
context deadline exceeded, these are partial results and may be missing replica states for some volumesWe expect this to be a rare case to hit