Conversation
mtodor
approved these changes
Jan 15, 2025
porridge
approved these changes
Jan 15, 2025
porridge
left a comment
porridge
left a comment
There was a problem hiding this comment.
LGTM, but I'd strongly suggest weekly or maybe even monthly to trim down on noise, and also bump the open PR limit. Maybe it's just my personal preference, but I find it easier to go through a batch of PRs rarely than have a never ending stream of them pop up all the time one at a time.
Collaborator
Author
|
@porridge Let's merge it as is. We have only 10 deps so this stream will be just a small brook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.