Skip to content

Add ibmcloud SecurityGroup dynamically for s390x CI vms#3219

Merged
ovalenti merged 4 commits intomasterfrom
jdao-add-ibmcloud-securitygroup
Apr 15, 2026
Merged

Add ibmcloud SecurityGroup dynamically for s390x CI vms#3219
ovalenti merged 4 commits intomasterfrom
jdao-add-ibmcloud-securitygroup

Conversation

@jdao-rh
Copy link
Copy Markdown
Contributor

@jdao-rh jdao-rh commented Apr 14, 2026

Description

Current IBMcloud for s390x VM's security group was removed by IBMcloud security for allowing ssh access from anywhere. This change creates a security group for the Ansible host IP dynamically

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.
Update to CI

Testing Performed

CI is able to create and SSH into s390x VMs

For more details, ref the Confluence page about this section.

@jdao-rh jdao-rh requested a review from a team as a code owner April 14, 2026 12:55
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.38%. Comparing base (e98bedf) to head (02cc196).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3219   +/-   ##
=======================================
  Coverage   27.38%   27.38%           
=======================================
  Files          95       95           
  Lines        5427     5427           
  Branches     2548     2548           
=======================================
  Hits         1486     1486           
  Misses       3214     3214           
  Partials      727      727           
Flag Coverage Δ
collector-unit-tests 27.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdao-rh jdao-rh changed the title Add ibmcloud SecurityGroup dynamically WIP Add ibmcloud SecurityGroup dynamically Apr 14, 2026
@jdao-rh jdao-rh changed the title WIP Add ibmcloud SecurityGroup dynamically Add ibmcloud SecurityGroup dynamically for s390x CI vms Apr 14, 2026
Copy link
Copy Markdown
Contributor

@ovalenti ovalenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this @jdao-rh !

@ovalenti ovalenti merged commit a494d4a into master Apr 15, 2026
91 of 97 checks passed
@ovalenti ovalenti deleted the jdao-add-ibmcloud-securitygroup branch April 15, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants