Skip to content

ROX-31317: disable mintmaker auto-approvals for release branches#2609

Merged
tommartensen merged 1 commit intomasterfrom
tm/ROX-31317-disable-mintmaker-auto-merges-for-release-branches
Oct 22, 2025
Merged

ROX-31317: disable mintmaker auto-approvals for release branches#2609
tommartensen merged 1 commit intomasterfrom
tm/ROX-31317-disable-mintmaker-auto-merges-for-release-branches

Conversation

@tommartensen
Copy link
Copy Markdown
Contributor

Description

See stackrox/scanner#2341.
We want to disable this to reduce noise & prevent things automatically going in the release branch between stable RC and final release.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

See stackrox/scanner#2341.

@tommartensen tommartensen requested a review from msugakov October 22, 2025 08:23
@tommartensen tommartensen self-assigned this Oct 22, 2025
@tommartensen tommartensen requested review from a team as code owners October 22, 2025 08:24
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.79%. Comparing base (ec8a0b3) to head (b22b211).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2609   +/-   ##
=======================================
  Coverage   28.79%   28.79%           
=======================================
  Files          95       95           
  Lines        5796     5796           
  Branches     2551     2551           
=======================================
  Hits         1669     1669           
  Misses       3409     3409           
  Partials      718      718           
Flag Coverage Δ
collector-unit-tests 28.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommartensen tommartensen enabled auto-merge (squash) October 22, 2025 08:55
@tommartensen tommartensen disabled auto-merge October 22, 2025 09:38
@tommartensen tommartensen merged commit 238d8b3 into master Oct 22, 2025
71 of 72 checks passed
@tommartensen tommartensen deleted the tm/ROX-31317-disable-mintmaker-auto-merges-for-release-branches branch October 22, 2025 11:48
tommartensen added a commit that referenced this pull request Oct 22, 2025
* ROX-31317: disable mintmaker auto-approvals for release branches (#2609)

* fix merge conflict
tommartensen added a commit that referenced this pull request Oct 22, 2025
* ROX-31317: disable mintmaker auto-approvals for release branches (#2609)

* fix merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants