fix(extension): only match tutorialkit content and meta files #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AriPerkkio
approved these changes
Aug 13, 2024
Member
AriPerkkio
left a comment
AriPerkkio
left a comment
There was a problem hiding this comment.
Tested locally in VSCode workspaces - works really well! 💯
I think we should get this fix released soon as it improves DX a lot.
Nemikolh
changed the title
Deploying tutorialkit-demo-page with
|
| Latest commit: |
e6e3a34
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eed19f1f.tutorialkit-demo-page.pages.dev |
| Branch Preview URL: | https://joan-fix-extensions-frontmat.tutorialkit-demo-page.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the autocompletion and validation for the frontmatter applies primarily to files that should be within a tutorialkit project. The heuristic used is very simple and not perfect so there could still be false positive. However, after this PR it will become very unlikely as one would need to create a markdown file named
meta.mdorcontent.md(x)under asrc/content/tutorialpath.Note that files under
_filesand_solutionare ignored as this could be a common situation where the extension would incorrectly perform validation and provide autocompletions.Closes #237