Skip to content

feat: Add generic database connection mechanism#722

Merged
adwk67 merged 11 commits intomainfrom
feat/generic-database-connection
Apr 22, 2026
Merged

feat: Add generic database connection mechanism#722
adwk67 merged 11 commits intomainfrom
feat/generic-database-connection

Conversation

@adwk67
Copy link
Copy Markdown
Member

@adwk67 adwk67 commented Apr 21, 2026

Description

Part of stackabletech/issues#238

🟢 Openshift:

--- PASS: kuttl (827.29s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/logging_superset-6.0.0_openshift-true (130.07s)
        --- PASS: kuttl/harness/oidc_superset-6.0.0_openshift-true (145.06s)
        --- PASS: kuttl/harness/external-access_superset-6.0.0_openshift-true (117.06s)
        --- PASS: kuttl/harness/opa_superset-6.0.0_opa-latest-1.12.3_openshift-true (279.19s)
        --- PASS: kuttl/harness/cluster-operation_superset-latest-6.0.0_openshift-true (171.86s)
        --- PASS: kuttl/harness/druid-connection_superset-6.0.0_openshift-true (108.01s)
        --- PASS: kuttl/harness/smoke_superset-6.0.0_openshift-true (121.00s)
        --- PASS: kuttl/harness/ldap_superset-6.0.0_ldap-authentication-server-verification-tls_openshift-true (123.83s)
        --- PASS: kuttl/harness/ldap_superset-6.0.0_ldap-authentication-insecure-tls_openshift-true (133.56s)
        --- PASS: kuttl/harness/resources_superset-latest-6.0.0_openshift-true (99.16s)
        --- PASS: kuttl/harness/ldap_superset-6.0.0_ldap-authentication-no-tls_openshift-true (128.67s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 added release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. scheduled-for/26.7.0 labels Apr 21, 2026
@adwk67 adwk67 marked this pull request as ready for review April 21, 2026 14:56
@adwk67 adwk67 requested review from maltesander and sbernauer April 21, 2026 14:57
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Apr 21, 2026
@adwk67 adwk67 self-assigned this Apr 21, 2026
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 22, 2026
Comment thread rust/operator-binary/src/crd/affinity.rs Outdated
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this already looks very good!

Comment thread deploy/config-spec/properties.yaml Outdated
Comment thread CHANGELOG.md
Comment thread rust/operator-binary/src/crd/affinity.rs Outdated
Comment thread rust/operator-binary/src/druid_connection_controller.rs Outdated
Comment thread rust/operator-binary/src/druid_connection_controller.rs Outdated
Comment thread docs/modules/superset/pages/usage-guide/database-connections.adoc Outdated
Comment thread docs/modules/superset/pages/usage-guide/database-connections.adoc Outdated
Comment thread docs/modules/superset/pages/usage-guide/database-connections.adoc Outdated
Comment thread docs/modules/superset/pages/getting_started/first_steps.adoc Outdated
Comment thread docs/modules/superset/pages/getting_started/first_steps.adoc Outdated
@adwk67
Copy link
Copy Markdown
Member Author

adwk67 commented Apr 22, 2026

sbernauer
sbernauer previously approved these changes Apr 22, 2026
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread CHANGELOG.md Outdated
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@adwk67 adwk67 added this pull request to the merge queue Apr 22, 2026
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Apr 22, 2026
Merged via the queue into main with commit 7da8744 Apr 22, 2026
12 checks passed
@adwk67 adwk67 deleted the feat/generic-database-connection branch April 22, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/26.7.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

3 participants