docs(crd): fix NiFi authorization usage guide link (usage-guide -> usage_guide)#924
Conversation
xeniape
left a comment
There was a problem hiding this comment.
LGTM thank you for opening a PR on this and fixing the broken link! :)
Just a small change request regarding the Changelog entry: The numbers actually reference the PRs not the issues
|
Could you also sign the CLA please? We need that to be able to accept the contribution ❤️ the link is in one of the above messages. |
|
Seems like the branch needs to resolve a small merge conflict, I can do that as well but didn't want to just meddle in your PR. Once that's done, I can approve 👍 |
…age_guide) The `spec.clusterConfig.authorization` CRD doc in `rust/operator-binary/src/crd/mod.rs` linked to `nifi/usage-guide/security#authorization` (with a hyphen), which 404s. Every other usage-guide link in this repo and the docs uses an underscore, e.g. `nifi/usage_guide/security#authentication`. Also regenerated the rendered link in `extra/crds.yaml` and added a CHANGELOG entry. Closes stackabletech#841
c9c24f5 to
27c6a8a
Compare
|
@xeniape rebased onto latest main. The CHANGELOG conflicts came from [#903], [#922], [#916], [#921] all landing while this sat — resolved by slotting the |
|
Thanks @xeniape — already addressed that in the rebase I pushed yesterday. The changelog now references |
Summary
The `spec.clusterConfig.authorization` CRD description links to the NiFi authorization usage guide using a hyphenated path:
```
https://docs.stackable.tech/home/stable/nifi/usage-guide/security#authorization
```
That URL 404s. Every other usage-guide link in this repo (`authentication`, `custom-components`, `extra-volumes`, `security`) uses `usage_guide` with an underscore, matching the actual docs path (`docs/modules/nifi/pages/usage_guide/security.adoc`).
Changes:
Closes #841
Testing
Documentation-only change. Verified: