Skip to content

fix!: Rework git-sync CRD to not fail on missing gitFolder#596

Merged
sbernauer merged 9 commits intomainfrom
fix/git-sync
Mar 17, 2025
Merged

fix!: Rework git-sync CRD to not fail on missing gitFolder#596
sbernauer merged 9 commits intomainfrom
fix/git-sync

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Mar 14, 2025

Description

If gitFolder was missing the stacklet was basically entirely broken.

For changes see CHANGELOG.md
For CRD change see deploy/helm/airflow-operator/crds/crds.yaml

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer sbernauer added customer-request type/bug release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. scheduled-for/25.3.0 labels Mar 14, 2025
@sbernauer sbernauer self-assigned this Mar 14, 2025
@sbernauer sbernauer moved this to Development: In Progress in Stackable Engineering Mar 14, 2025
Comment thread CHANGELOG.md
@sbernauer
Copy link
Copy Markdown
Member Author

Please vote for the CRD change on this comment

Comment thread deploy/helm/airflow-operator/crds/crds.yaml Outdated
Comment thread tests/templates/kuttl/mount-dags-gitsync/30-install-airflow-cluster.yaml.j2 Outdated
@sbernauer
Copy link
Copy Markdown
Member Author

@sbernauer
Copy link
Copy Markdown
Member Author

Decision was accepted during the daily 2025-03-17

Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Mar 17, 2025
@sbernauer sbernauer moved this from Development: In Progress to Development: Done in Stackable Engineering Mar 17, 2025
Merged via the queue into main with commit 5c96137 Mar 17, 2025
16 of 17 checks passed
@sbernauer sbernauer deleted the fix/git-sync branch March 17, 2025 13:01
@sbernauer
Copy link
Copy Markdown
Member Author

Release notes test comment :)

- BREAKING: The field `.spec.clusterConfig.dagsGitSync[].wait` changed from `uint8` to our human-readable `Duration` struct.
In case you have used `wait: 20` before, you need to change it to `wait: 20s` ([#596]).

@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-request release/25.3.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. type/bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants