Skip to content

Just use 'okio' for the automatic module name.#343

Merged
swankjesse merged 1 commit intomasterfrom
jwilson.0204.module_name_okio
Feb 5, 2018
Merged

Just use 'okio' for the automatic module name.#343
swankjesse merged 1 commit intomasterfrom
jwilson.0204.module_name_okio

Conversation

@swankjesse
Copy link
Collaborator

No description provided.

@JakeWharton
Copy link
Collaborator

What changed your mind? I prefer the old one.

@kashike
Copy link
Contributor

kashike commented Feb 4, 2018

@JakeWharton
Copy link
Collaborator

I don't want to use 'retrofit2' for Retrofit. Matching package names is for people who have qualified package names.

@swankjesse
Copy link
Collaborator Author

Discussed offline. Automatic-Module-Names shall be package names!

@swankjesse swankjesse merged commit 2f65947 into master Feb 5, 2018
@swankjesse swankjesse deleted the jwilson.0204.module_name_okio branch February 11, 2018 21:29
15characterlimi pushed a commit to 15characterlimi/okio that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants