Add 'Automatic-Module-Name' entry to manifest

[kashike]

adds #339

[swankjesse]

I think we want com.squareup.okio ?

[kashike]

@swankjesse square/okhttp#3743 (comment)

I think using ${project.groupId} in the module name setup is unwise. The module name is just as much a part of your source code as the package name is, and should be treated as part of your API for compatibility purposes. Just encode the full name in the pom.xml so it doesn't get changed. In addition, Maven artifact and group IDs are often bad guidance for module names. Focus on the package names, and you'll be fine.

[JakeWharton]

That advice is for those whose package names are already prefixed with something like com.squareup which this library is not.

…

On Fri, Feb 2, 2018, 8:46 PM kashike ***@***.***> wrote: @swankjesse <https://github.com/swankjesse> square/okhttp#3743 (comment) <square/okhttp#3743 (comment)> I think using ${project.groupId} in the module name setup is unwise. The module name is just as much a part of your source code as the package name is, and should be treated as part of your API for compatibility purposes. Just encode the full name in the pom.xml so it doesn't get changed. In addition, Maven artifact and group IDs are often bad guidance for module names. Focus on the package names, and you'll be fine. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#340 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEWr94zShCsGBxaBywd1R_aN7HRPNks5tQ2YqgaJpZM4R2nTR> .

[kashike]

@JakeWharton square/okhttp#3743 (comment)
Package name is okio: https://github.com/square/okio/tree/master/okio/src/main/java/okio.

Your module name should be the same as the package name in that jar file, unless you have a good reason otherwise. ie. you as a human are deciding that one package is the base, and assigning that as the module name. Thus the okhttp3 pom.xml would declare a module name of okhttp3 (I dislike that this is not com.squareup.okhttp3 but you should still match the package name)

[JakeWharton]

I don't agree with that, and it's not official policy anyway.

…

On Sat, Feb 3, 2018, 10:26 AM kashike ***@***.***> wrote: @JakeWharton <https://github.com/jakewharton> square/okhttp#3743 (comment) <square/okhttp#3743 (comment)> Package name is okio: https://github.com/square/okio/tree/master/okio/src/main/java/okio. Your module name should be the same as the package name in that jar file, unless you have a good reason otherwise. ie. you as a human are deciding that one package is the base, and assigning that as the module name. Thus the okhttp3 pom.xml would declare a module name of okhttp3 (I dislike that this is not com.squareup.okhttp3 but you should still match the package name) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#340 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEdb77omCPveEBdWorzizKEMFe9BTks5tRCZGgaJpZM4R2nTR> .

[kashike]

Alright, there you go then.