cache: guard null fields in Entry.writeTo() to fix NPE (#8962)#9345
Open
iVamsi wants to merge 1 commit intosquare:masterfrom
Open
cache: guard null fields in Entry.writeTo() to fix NPE (#8962)#9345iVamsi wants to merge 1 commit intosquare:masterfrom
iVamsi wants to merge 1 commit intosquare:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
NullPointerExceptioninCache.Entry.writeTo()when an HTTPS response has a null handshake.Fix
Changed
if (url.isHttps)toif (url.isHttps && handshake != null)so the TLS block is skipped when handshake is absent. The response still succeeds. It just won't be served from cache on subsequent requests.Tests added
Three regression tests in
CacheTest:writeTo().All verified to fail before the fix and pass after.
Fixes #8962