Temporarily remove ConnectionListener from the public API#8831
Merged
swankjesse merged 1 commit intomasterfrom May 30, 2025
Merged
Temporarily remove ConnectionListener from the public API#8831swankjesse merged 1 commit intomasterfrom
swankjesse merged 1 commit intomasterfrom
Conversation
I'd like to update the API to improve observability into things like ConnecitonPool, RoutePlanner, ConnectPlan, and ReusePlan. And also into HTTP/2 internals like flow-control. As-is this is more coupled to Call lifecycles and is somewhat duplicative with ConnectionPool. We'll do that work and make it a new public API, but we won't have it in the public API at all for the 5.0 release.
swankjesse
commented
May 30, 2025
Collaborator
Author
There was a problem hiding this comment.
Deleted but not forgotten! We’ll bring this back.
yschimke
approved these changes
May 30, 2025
yschimke
added a commit
to yschimke/okhttp
that referenced
this pull request
Aug 4, 2025
…uare#8831)" This reverts commit 80c71d2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to update the API to improve observability into things like ConnecitonPool, RoutePlanner, ConnectPlan, and ReusePlan. And also into HTTP/2 internals like flow-control.
As-is this is more coupled to Call lifecycles and is somewhat duplicative with ConnectionPool.
We'll do that work and make it a new public API, but we won't have it in the public API at all for the 5.0 release.