Add multi-release jars to enable Java Modules by yschimke · Pull Request #8767 · square/okhttp

yschimke · 2025-05-11T14:52:56Z

Attempting to apply multi-release Jars and use it to add java9/module-info.java files.

This should run a HTTP request against square.com using a jlink image.

./gradle module-tests:imageRun

fixes #4184

Todo

Enable OkHttp modules in the test to flush out errors
Setup a CI job probably testing against Mockserver

yschimke · 2025-05-11T20:11:12Z

~~Current status!~~ resolved

Exception in thread "main" java.lang.IllegalAccessError: class okhttp3.internal.concurrent.TaskRunner (in module okhttp3) cannot access class java.util.logging.Logger (in module java.logging) because module okhttp3 does not read module java.logging
	at okhttp3/okhttp3.internal.concurrent.TaskRunner.<clinit>(TaskRunner.kt:362)

buildSrc/build.gradle.kts

yschimke · 2025-06-18T08:32:40Z

Is this post 5.0?

# Conflicts: # okhttp/build.gradle.kts

# Conflicts: # buildSrc/build.gradle.kts # okhttp/build.gradle.kts

# Conflicts: # gradle/libs.versions.toml

yschimke · 2025-07-12T16:06:46Z

@swankjesse appropriate for 5.2?

swankjesse

The code looks fine but I don’t much appreciate what it buys us or our users?

android-test/build.gradle.kts

buildSrc/src/main/kotlin/JavaModules.kt

mockwebserver-deprecated/src/main/java9/module-info.java

mockwebserver-junit4/build.gradle.kts

module-tests/build.gradle.kts

swankjesse · 2025-07-15T22:24:44Z

module-tests/src/main/java/module-info.java

@@ -0,0 +1,6 @@
+module okhttp3.modules {
+  requires okhttp3;
+  requires okhttp3.logging;


what the heck is okhttp3.logging ?!

https://github.com/square/okhttp/blob/master/okhttp-logging-interceptor%2Fbuild.gradle.kts#L13

#3743 (comment)

I think I misread your comment.

Or maybe favoured Stephen's comment over yours?

Your module name should be the same as the package name in that jar file, unless you have a good reason otherwise. ie. you as a human are deciding that one package is the base, and assigning that as the module name.

Yep yep, it’s the package name. I missed that we gave that module two different names.

module-tests/src/main/java/okhttp3/modules/OkHttpCaller.java

swankjesse · 2025-07-15T22:25:54Z

module-tests/src/test/java/module-info.java

+  requires jdk.crypto.ec;
+  requires org.junit.jupiter.api;
+  requires okhttp3.modules;
+  opens okhttp3.modules.test to org.junit.platform.commons;


Do any developers do stuff like this in the wild?

Yep - https://github.com/search?q=opens+org.junit.platform.commons&type=code

See https://info.michael-simons.eu/2021/10/19/testing-in-a-modular-world/

swankjesse · 2025-07-15T22:27:42Z

okhttp/src/jvmMain/java9/module-info.java

+  exports okhttp3;
+  exports okhttp3.internal to okhttp3.logging, okhttp3.sse, okhttp3.java.net.cookiejar, okhttp3.dnsoverhttps, mockwebserver3, okhttp3.mockwebserver, okhttp3.coroutines, okhttp3.tls;
+  exports okhttp3.internal.platform to okhttp3.logging, okhttp3.java.net.cookiejar, okhttp3.dnsoverhttps, mockwebserver3, okhttp3.mockwebserver, okhttp3.tls;
+  exports okhttp3.internal.http to okhttp3.logging, okhttp3.brotli, mockwebserver3;


I’m still curious about what okhttp3.logging is

A mistake from 2018...

yschimke · 2025-07-19T09:33:42Z

README.md

+error: package okhttp3.internal.platform is not visible
+    okhttp3.internal.platform.Platform.get();
+                    ^
+  (package okhttp3.internal.platform is declared in module okhttp3,
+    which does not export it to module i.am.bad.and.i.should.feel.bad)


@swankjesse I guess this is the main point?

Also added a CI test that jlink works, see https://www.baeldung.com/jlink

Also https://snyk.io/blog/jlink-create-docker-images-spring-boot-java/

@swankjesse do you need more convincing?

This is good behavior. I wouldn’t use i.am.bad.and.i.should.feel.bad as the example; this is not a place for shame

yschimke · 2025-09-20T17:06:42Z

@swankjesse requesting post review.

Seems like a net good to support something some users are adopting. Happy to revert if you are completely against it.

swankjesse

LGTM!

swankjesse · 2025-10-02T20:01:56Z

README.md

+error: package okhttp3.internal.platform is not visible
+    okhttp3.internal.platform.Platform.get();
+                    ^
+  (package okhttp3.internal.platform is declared in module okhttp3,
+    which does not export it to module i.am.bad.and.i.should.feel.bad)


This is good behavior. I wouldn’t use i.am.bad.and.i.should.feel.bad as the example; this is not a place for shame

swankjesse · 2025-10-02T20:10:50Z

buildSrc/src/main/kotlin/JavaModules.kt

+    // not needed when compiling with recent JDKs, e.g. 17
+    options.compilerArgs.add("-Xlint:-requires-transitive-automatic")
+
+    // Patch the compileKotlinJvm output classes into the compilation so exporting packages works correctly.


Very helpful comment!

swankjesse · 2025-10-02T20:14:16Z

module-tests/src/main/java/module-info.java

@@ -0,0 +1,6 @@
+module okhttp3.modules {
+  requires okhttp3;
+  requires okhttp3.logging;


Yep yep, it’s the package name. I missed that we gave that module two different names.

swankjesse · 2025-10-02T20:18:21Z

okhttp/build.gradle.kts

+  // Note that module checking only works on JDK 9+,
+  // because the JDK built-in base modules are not available in earlier versions.
+  val javaVersion = compileKotlinTask.kotlinJavaToolchain.javaVersion.getOrNull()
+  when {


I don’t really understand what this when{} is supposed to be doing

swankjesse · 2025-10-02T20:21:37Z

okhttp/build.gradle.kts

 }

+// From https://github.com/Kotlin/kotlinx-atomicfu/blob/master/atomicfu/build.gradle.kts
+val compileJavaModuleInfo by tasks.registering(JavaCompile::class) {


Please refactor this so it’s the same applyJavaModules() call we have in all of our other modules? Having two copy-pastes of this configuration will confuse me for all time

(You could definitely have a parameter to toggle the options that only the okhttp module needs? Why doesn’t this module use me.champeau.mrjar?!)

swankjesse · 2025-10-02T20:26:42Z

README.md

+Java Modules
+------------
+
+OkHttp (5.3+) implements Java 9 Modules.


What the heck is OkHttp 5.3 ?! We have to ship 5.2 first!

Ooops, can fix.

Add multi-release jars to enable Java Modules

b72276a

yschimke requested a review from JakeWharton May 11, 2025 14:53

yschimke added android Relates to usage specifically on Android providers Non core security providers jdkversions JDK 8, 17, 19 etc. labels May 11, 2025

yschimke added 3 commits May 11, 2025 16:06

Fix android tests

ab042de

document todo

879bf1a

Validate more modules

69df152

yschimke marked this pull request as ready for review May 11, 2025 15:53

yschimke added 3 commits May 11, 2025 17:28

Fix

ac24e72

Add a test module compiling using Java modules

ce79429

Avoid running module tests on JDK 8

fe7e549

yschimke added 2 commits May 11, 2025 21:45

Add a jlink run task to demonstrate java modules

a828dc7

Merge branch 'master' into mrjar

14e6e16

yschimke requested a review from swankjesse May 26, 2025 10:56

yschimke added 3 commits May 29, 2025 07:44

Merge branch 'master' into mrjar

b268038

Merge branch 'master' into mrjar

71057d1

Fix version

f1a2f03

yschimke commented Jun 18, 2025

View reviewed changes

buildSrc/build.gradle.kts Outdated Show resolved Hide resolved

yschimke added 4 commits June 21, 2025 11:03

Merge branch 'refs/heads/master' into mrjar

c56f1e6

# Conflicts: # okhttp/build.gradle.kts

Update

aca5013

Merge remote-tracking branch 'yschimke/mrjar' into mrjar

8b49e10

# Conflicts: # buildSrc/build.gradle.kts # okhttp/build.gradle.kts

Remove old comment

0973e8d

yschimke added this to the 5.x milestone Jun 22, 2025

yschimke mentioned this pull request Jul 8, 2025

Add Module Support for OkHttp to Improve Compatibility with jlink and Java 9+ Modules #8588

Closed

yschimke added 2 commits July 12, 2025 16:30

Merge branch 'master' into mrjar

2cf11d3

# Conflicts: # gradle/libs.versions.toml

Update module test

1ba44f1

swankjesse reviewed Jul 15, 2025

View reviewed changes

Merge branch 'master' into mrjar

7eef165

yschimke mentioned this pull request Jul 19, 2025

Add Java Module tests that we export the right set #8952

Open

yschimke added 4 commits July 19, 2025 10:18

cleanup and document

6a3a64b

suppress module warnings

2b452f7

add

220529b

add

c2bb349

yschimke commented Jul 19, 2025

View reviewed changes

yschimke added 4 commits July 19, 2025 10:35

readme

1488a1b

add more modules

b028111

Fix

fb8636d

Run with Jlink

45ec46b

yschimke mentioned this pull request Jul 19, 2025

JPMS support #4184

Closed

yschimke added 4 commits July 19, 2025 11:28

Add mockwebserver test

d9d121f

Fix build

2398c5a

Fix build

c6bf693

Merge branch 'master' into mrjar

16cb3a2

yschimke mentioned this pull request Jul 26, 2025

Unknown enum constant DeprecationLevel #8194

Closed

yschimke added 6 commits July 27, 2025 13:21

Merge branch 'master' into mrjar

17f6354

Merge branch 'master' into mrjar

473ce2c

Merge branch 'master' into mrjar

9a6f004

Fix build

cb0dedd

Merge branch 'master' into mrjar

37161cd

Merge branch 'master' into mrjar

d9c1199

yschimke merged commit b7290e4 into square:master Sep 21, 2025
26 checks passed

swankjesse reviewed Oct 2, 2025

View reviewed changes

This was referenced Oct 3, 2025

Fix comments from modules PR #9102

Merged

Gradle refactor applyJavaModules() #9103

Open

Conversation

yschimke commented May 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yschimke commented May 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

yschimke commented Jun 18, 2025

Uh oh!

yschimke commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swankjesse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yschimke Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yschimke commented Sep 20, 2025

Uh oh!

Uh oh!

swankjesse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

yschimke commented May 11, 2025 •

edited

Loading

yschimke commented May 11, 2025 •

edited

Loading

yschimke commented Jul 12, 2025 •

edited

Loading

yschimke Jul 19, 2025 •

edited

Loading