Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Adds Flow#updateHistory(HistoryUpdater)#239

Closed
rjrjr wants to merge 1 commit intomasterfrom
ray/functional
Closed

Adds Flow#updateHistory(HistoryUpdater)#239
rjrjr wants to merge 1 commit intomasterfrom
ray/functional

Conversation

@rjrjr
Copy link
Contributor

@rjrjr rjrjr commented Apr 14, 2017

In response to the discussion in #197. Allows app code to mutate the history
safely despite the raciness of asynchronous transitions.

@rjrjr
Copy link
Contributor Author

rjrjr commented Apr 14, 2017

Note that exposing HistoryUpdater.DoSet is very intentional. I have had to replicate that in app code more than once, can't imagine I'm the only one.

In response to the discussion in #197. Allows app code to mutate the history
safely despite the raciness of asynchronous transitions.
@edenman
Copy link
Contributor

edenman commented Apr 14, 2017

I like this alot.

@rjrjr
Copy link
Contributor Author

rjrjr commented Apr 14, 2017

Offline discussion w/@loganj, we're reluctant to open this up hook without thinking about it a bit more. Is the queue really something we should be exposing even more like this, or would that get in the way of a longer term vision that eliminates the need for it?

@rjrjr rjrjr closed this Apr 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants