feat: bundler-friendly fixes & bumped version for release #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be227fc1ce973f4ad0d) (#17) Co-authored-by: jurerotar <[email protected]>
…078f4526b90a5caa03c) (#18) Co-authored-by: jurerotar <[email protected]>
Collaborator
|
Let me know when you want me to have a look. |
Contributor
Author
|
I think we’re good to go here! I’ve expanded the test suite a bit more today, but the tests I’ve added yesterday are the important ones for this issue 😄 |
Contributor
Author
|
Happy to confirm it works perfectly now! Thank you for all the help! 😄 |
Collaborator
The SQLite community has to thank you! Fantastic work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added tests specifically to test bundler output (vite only for now). Test was ran with previous version and it failed (which was supposed to happen), so we can be a tiny bit more sure with future releases now 😄