Skip to content

Conversation

@larsoner
Copy link
Collaborator

@mgeier locally this worked:

$ python setup.py bdist_wheel
...
$ $ ls dist/
rtmixer-0.1.5-cp38-abi3-macosx_11_0_arm64.whl

and then I could install it, too.

@pep8speaks
Copy link

pep8speaks commented Jun 27, 2024

Hello @larsoner! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-06-28 14:13:59 UTC

@larsoner
Copy link
Collaborator Author

Argh this will work for CPython only. Should we drop PyPy support or incorporate separate wheel build / logic (probably with scripts)? For example the audit command will vary depending on whether PyPy or CPython wheels are being built.

@mgeier
Copy link
Member

mgeier commented Jun 28, 2024

I don't know if there are any potential PyPy users, but as a matter of principle I would like to keep providing PyPy wheels.

If it is too complicated, we can just keep generating wheels for all CPython versions as well. This seems to be what most projects are doing.

Maybe we should just wait until cibuildwheel supports what we want out-of-the-box?

@larsoner
Copy link
Collaborator Author

Okay it wasn't too bad -- I realized I could use build selector ORs with {} to get what we wanted without too much work. Then only the repair command needed to be changed / set based on whether CPython (and thus abi3 mode) was being used or not.

@larsoner
Copy link
Collaborator Author

larsoner commented Jul 2, 2024

I'll merge this and cut 0.1.6 and we can see if it works! 🤞

@larsoner larsoner merged commit 505ecd0 into spatialaudio:master Jul 2, 2024
@larsoner larsoner deleted the abi3 branch July 2, 2024 16:10
@mgeier
Copy link
Member

mgeier commented Jul 13, 2024

Thanks a lot @larsoner, this works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants