Skip to content

Conversation

@burmudar
Copy link
Contributor

@burmudar burmudar commented Jun 1, 2022

Soft fail when we get rate limited by github. See this job for a case where this happens

Test plan

Unit tests

@burmudar burmudar requested a review from bobheadxi June 1, 2022 17:10
@sourcegraph-bot
Copy link

Codenotify: Notifying subscribers in CODENOTIFY files for diff 4bd0cba...7cab8dc.

Notify File(s)
@nicksnyder main.go
main_test.go

Copy link
Member

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 😁

@burmudar burmudar merged commit 0cf14e0 into main Jun 1, 2022
@burmudar burmudar deleted the wbezuide/api-rate-limit-soft-fail branch June 1, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants