Skip to content

feat(web): hide security notice when EXPERIMENT_ASK_GH_ENABLED is true#943

Merged
msukkari merged 2 commits intomainfrom
msukkari/hide-security-notice
Feb 26, 2026
Merged

feat(web): hide security notice when EXPERIMENT_ASK_GH_ENABLED is true#943
msukkari merged 2 commits intomainfrom
msukkari/hide-security-notice

Conversation

@msukkari
Copy link
Contributor

@msukkari msukkari commented Feb 26, 2026

Hide the "Authentication data is managed by your deployment" security notice on login and signup pages when the EXPERIMENT_ASK_GH_ENABLED flag is enabled.

The security notice is now conditionally hidden in both the login and signup forms when this experiment flag is true, keeping the UI cleaner for experimental configurations.

Summary by CodeRabbit

  • New Features
    • Security notice on login and signup pages can now be conditionally hidden based on experimental settings.

Hide the "Authentication data is managed by your deployment" security notice on login and signup pages when the EXPERIMENT_ASK_GH_ENABLED flag is enabled.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@github-actions

This comment has been minimized.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d2d4bb and 434a20f.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • packages/web/src/app/login/components/loginForm.tsx
  • packages/web/src/app/login/page.tsx
  • packages/web/src/app/signup/page.tsx

Walkthrough

Adds an optional hideSecurityNotice prop to the LoginForm component and conditionally passes it based on the EXPERIMENT_ASK_GH_ENABLED environment variable in login and signup pages to hide the security notice.

Changes

Cohort / File(s) Summary
Documentation
CHANGELOG.md
Added changelog entry documenting the new behavior of hiding the security notice on login/signup pages when the experiment flag is enabled.
Component Definition
packages/web/src/app/login/components/loginForm.tsx
Added optional hideSecurityNotice boolean prop to LoginForm component signature and propagated it to the AuthMethodSelector child component.
Feature Integration
packages/web/src/app/login/page.tsx, packages/web/src/app/signup/page.tsx
Added imports for environment configuration and passed hideSecurityNotice prop to LoginForm component, controlled by the EXPERIMENT_ASK_GH_ENABLED feature flag.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • brendan-kellam
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and specifically describes the main change: hiding the security notice when EXPERIMENT_ASK_GH_ENABLED is true, which aligns with the actual changes across CHANGELOG.md, loginForm.tsx, login/page.tsx, and signup/page.tsx.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch msukkari/hide-security-notice

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@msukkari msukkari merged commit 355d7c0 into main Feb 26, 2026
9 checks passed
@msukkari msukkari deleted the msukkari/hide-security-notice branch February 26, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant