Skip to content

Change setting method of the DRM device filename.#10

Merged
HidenoriMatsubayashi merged 11 commits intomasterfrom
unknown repository
Mar 11, 2021
Merged

Change setting method of the DRM device filename.#10
HidenoriMatsubayashi merged 11 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 10, 2021

I changed the setting method of the DRM device filename from the fixed value to the environment variable.

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 10, 2021

@HidenoriMatsubayashi
May I request you to review?

@HidenoriMatsubayashi
Copy link
Copy Markdown
Contributor

Could you link a related issue from next time?
#9

@ghost ghost linked an issue Mar 10, 2021 that may be closed by this pull request
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 10, 2021

Could you link a related issue from next time?
#9

Sorry, I'll link a related issue next time.

Copy link
Copy Markdown
Contributor

@HidenoriMatsubayashi HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

Comment thread src/flutter/shell/platform/linux_embedded/window/linuxes_window_drm.cc Outdated
Comment thread src/flutter/shell/platform/linux_embedded/window/linuxes_window_drm.cc Outdated
Comment thread README.md Outdated
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 10, 2021

@HidenoriMatsubayashi
I fixed the code. Please re-review.

Comment thread src/flutter/shell/platform/linux_embedded/window/linuxes_window_drm.cc Outdated
Comment thread README.md Outdated
Comment thread README.md
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 11, 2021

@HidenoriMatsubayashi
I fixed the code. Please re-review.

Copy link
Copy Markdown
Contributor

@HidenoriMatsubayashi HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments

Comment thread src/flutter/shell/platform/linux_embedded/window/linuxes_window_drm.cc Outdated
Comment thread src/flutter/shell/platform/linux_embedded/window/linuxes_window_drm.cc Outdated
Comment thread README.md Outdated
Comment thread examples/flutter-drm-backend/README.md
Copy link
Copy Markdown
Contributor

@HidenoriMatsubayashi HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments...

Comment thread examples/flutter-drm-backend/README.md Outdated
Comment thread examples/flutter-drm-backend/README.md Outdated
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 11, 2021

@HidenoriMatsubayashi
I fixed the README files. Please re-review.

Copy link
Copy Markdown
Contributor

@HidenoriMatsubayashi HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the comments.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@HidenoriMatsubayashi HidenoriMatsubayashi merged commit a718896 into sony:master Mar 11, 2021
@HidenoriMatsubayashi
Copy link
Copy Markdown
Contributor

LGTM

@ghost ghost deleted the replace-drm-filename branch April 21, 2021 01:42
mchabsonel pushed a commit to SonelSA/flutter-embedded-linux that referenced this pull request Oct 19, 2025
mchabsonel pushed a commit to SonelSA/flutter-embedded-linux that referenced this pull request Oct 19, 2025
This change fixes the following error messages when using upgrade command.

```
$ flutter-elinux upgrade
flutter-elinux is already up to date

Null check operator used on a null value
#0      ELinuxUpgradeCommandRunner.runCommandFirstHalf (package:flutter_elinux/commands/upgrade.dart:99:49)
<asynchronous suspension>
sony#1      ELinuxUpgradeCommandRunner.runCommand (package:flutter_elinux/commands/upgrade.dart:72:7)
<asynchronous suspension>
sony#2      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1297:27)
<asynchronous suspension>
sony#3      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
sony#4      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
sony#5      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:339:9)
<asynchronous suspension>
sony#6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
sony#7      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:285:5)
<asynchronous suspension>
sony#8      run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:115:9)
<asynchronous suspension>
sony#9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
sony#10     main (package:flutter_elinux/executable.dart:80:3)
<asynchronous suspension>
```

Signed-off-by: Hidenori Matsubayashi <Hidenori.Matsubayashi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doesn't work on Raspberry Pi4 when using DRM backend

1 participant