Remove .env file creation #409
Conversation
rjhenry
force-pushed
the
rjh_remove_entrypoint_script
branch
from
1e2dced to
8b233ae
Compare
rjhenry
force-pushed
the
rjh_remove_entrypoint_script
branch
from
3c6aa55 to
92f542d
Compare
stavros-k
left a comment
stavros-k
left a comment
There was a problem hiding this comment.
LGTM so far, looking forward to it!
Maybe also remove the php artisan generate key? Since now it won't go forward if the APP_KEY is not set.
✅
docker-entrypoint.sh
Outdated
| fi | ||
| fi | ||
| # Ensure these is no local .env file | ||
| [ -f ".env" ] && rm .env |
There was a problem hiding this comment.
Maybe instead of deleting it, having error out with a log message to something like "please migrate the .env values into your compose or docker run setup"
Just to avoid custom configs being lost.
Or at least my .env .env.bak
There was a problem hiding this comment.
That makes sense - I've adjusted this now.
|
Is there anything I can help with to complete this? |
rjhenry
force-pushed
the
rjh_remove_entrypoint_script
branch
from
8785db9 to
2bfe6aa
Compare
I've just updated the documentation change to reflect the changed version number, so as long as the automated tests pass I'll be merging this later on today. Thanks for the offer though! |
No description provided.