Porting templates from SolidStart repository#202
Conversation
There was a problem hiding this comment.
Overall this LGTM.
Just need a bit of cleanup. I see some build (.vinxi) directories that shouldn't be there. It would be good to add .vinxi to .gitignore, after the folders have been removed from the pr
e.g.
solid-start/with-vitest/.vinxi/build/client/_build etc.
| @@ -0,0 +1,7 @@ | |||
| ZERO_UPSTREAM_DB="postgresql://user:password@127.0.0.1/zstart_solid" | |||
| ZERO_CVR_DB="postgresql://user:password@127.0.0.1/zstart_solid_cvr" | |||
| ZERO_CHANGE_DB="postgresql://user:password@127.0.0.1/zstart_solid_cdb" | |||
There was a problem hiding this comment.
should there be more files in this example? or was this not meant to be copied over?
examples/with-drizzle-zero-better-auth/
There was a problem hiding this comment.
bad copy/paste from a test. Sorry
|
Will these automatically be available in the vite cli or do we need to wire that up? I assume we will have to change the solid-cli for sure |
atilafassina
force-pushed
the
bring-solidstart-templates
branch
2 times, most recently
from
224c19b to
771bf71
Compare
thanks. Yeah, I expected them to be ignored, and ended up being lazy on the copy/paste. Fixed it now. |
no, there's a one-line change that is required. But we need this on |
atilafassina
force-pushed
the
bring-solidstart-templates
branch
from
771bf71 to
1e1bb94
Compare
atilafassina
force-pushed
the
bring-solidstart-templates
branch
from
1e1bb94 to
aaf7899
Compare
3 participants
Currently the Solid CLI pulls the
/examplesfolder from the SolidStart repository.This PR ports them over here so the CLI can ping a single place to pull every template from the same place.
Furhtermore,
/examplesin SolidStart will be replaced as/fixturesfor testing more specific development cases.Not porting
as I believe those are not useful as templates but as demos.