Skip to content

fix: OAuth 응답에 isRegistered 추가#701

Merged
whqtker merged 1 commit intodevelopfrom
fix/oauth-response-add-is-registered
Mar 19, 2026
Merged

fix: OAuth 응답에 isRegistered 추가#701
whqtker merged 1 commit intodevelopfrom
fix/oauth-response-add-is-registered

Conversation

@whqtker
Copy link
Member

@whqtker whqtker commented Mar 19, 2026

관련 이슈

  • resolves: #이슈 번호

작업 내용

특이 사항

리뷰 요구사항 (선택)

@whqtker whqtker self-assigned this Mar 19, 2026
@whqtker whqtker added the 버그 Something isn't working label Mar 19, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 316ebb27-71ce-4e28-b697-adfcac3e100b

📥 Commits

Reviewing files that changed from the base of the PR and between 9f63826 and 9e23031.

📒 Files selected for processing (3)
  • src/main/java/com/example/solidconnection/auth/dto/oauth/OAuthSignInResponse.java
  • src/main/java/com/example/solidconnection/auth/dto/oauth/SignUpPrepareResponse.java
  • src/test/java/com/example/solidconnection/auth/service/oauth/OAuthServiceTest.java

워크스루

이 변경사항은 OAuth 인증 응답 DTOs에 사용자 등록 여부를 나타내는 필드를 추가하는 작업입니다. 다음과 같이 구성됩니다:

  1. OAuthSignInResponse 레코드 수정boolean isRegistered 컴포넌트를 추가하고, 팩토리 메서드 from()에서 기존 사용자 로그인 시 true 값으로 설정하도록 갱신했습니다.

  2. SignUpPrepareResponse 레코드 수정 — 동일하게 boolean isRegistered 컴포넌트를 추가하고, 팩토리 메서드 of()에서 신규 사용자 가입 준비 시 false 값으로 설정하도록 변경했습니다.

  3. 테스트 검증 추가 — OAuthServiceTest에 등록 상태 플래그를 검증하는 단언문 2개를 기존 assertAll 블록에 통합했습니다.

예상 코드 리뷰 난이도

🎯 2 (Simple) | ⏱️ ~12 분

제안 리뷰어

  • wibaek
  • Hexeong
  • lsy1307
  • JAEHEE25
🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR 설명이 템플릿 구조만 포함하고 있으며, 구체적인 작업 내용, 특이 사항, 리뷰 요구사항이 모두 채워지지 않았습니다. 작업 내용 섹션에 isRegistered 필드 추가의 목적과 변경 범위를 구체적으로 기술하고, 필요시 특이 사항이나 리뷰 요구사항을 추가해주세요.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed 제목은 주요 변경사항인 OAuth 응답에 isRegistered 필드 추가를 명확하게 요약하고 있습니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/oauth-response-add-is-registered
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

@whqtker whqtker merged commit b58d893 into develop Mar 19, 2026
3 checks passed
@whqtker whqtker deleted the fix/oauth-response-add-is-registered branch March 19, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

버그 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant