Provides full coverage for shared functions (shared.js)#99
Open
erikyo wants to merge 1 commit intosmhg:developmentfrom
Open
Provides full coverage for shared functions (shared.js)#99erikyo wants to merge 1 commit intosmhg:developmentfrom
erikyo wants to merge 1 commit intosmhg:developmentfrom
Conversation
johnhooks
reviewed
May 26, 2024
johnhooks
reviewed
May 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers 'shared' functions with tests
@johnhooks can you take a look at this? I tested the result with the original function, and with the current updated code and it seems there are some issues, and this condition cannot be verified:
gettext-parser/lib/shared.js
Lines 116 to 120 in d8dcbee
Precisely in this row (from the original shared.js before any modification):
while (curLine.substr(-1) === '\\' && pos + curLine.length < len) {It was intended
\\\\and not\\?