-
Notifications
You must be signed in to change notification settings - Fork 291
Closed
Labels
bugneeds triageWaiting for discussion / prioritization by teamWaiting for discussion / prioritization by team
Milestone
Description
When we made this change in Nov 2024 (6486532):
--- a/.goreleaser.yml
+++ b/.goreleaser.yml
@@ -53,11 +53,9 @@ builds:
# - the name of the output binary is step-cli
<< : *BUILD
id: nfpm
- goos:
- - linux
- goarch:
- - amd64
- - arm64
+ targets:
+ - linux_amd64
+ - linux_arm64
binary: step-cli
After this change, the number of supported architectures for step-cli rpm and deb builds went from 8 to 2.
Before 6486532:
- targets was inherited from &BUILD (all Linux architectures)
- goos/goarch were explicitly set to linux + amd64/arm64
- Since targets takes precedence, GoReleaser used the inherited targets → many architectures
After 6486532:
- targets was explicitly set to linux_amd64, linux_arm64
- This overrides the inherited targets from &BUILD → only 2 architectures
Here's 0.28.0 from our GCS bucket:
And here's 0.28.2:
My proposed fix is to build rpms and debs for all the same arches that we already build binaries for.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugneeds triageWaiting for discussion / prioritization by teamWaiting for discussion / prioritization by team