False positive when using wrong slack token

[Mrizwanshaik]

I recently integrated slackapi/slack-github-action@* into our GitHub workflow configuration to receive Slack notifications. Although the workflow ran successfully, it did not post any messages to the Slack channel. Upon further investigation, we discovered that the action was not correctly authenticating the token. Instead, it was simply expecting a token string and, despite the authentication failure, marked the job as successful.

[zimeg]

Hey @Mrizwanshaik! 👋 Thanks for sharing this report with us!

This isn't clear in documentation at the moment, but I believe the action is working as expected:

Invalid API requests or unexpected webhook payloads cause a failing response that can be used to fail the GitHub Actions step with the errors option.

The errors option defaults to false so failed requests do not cause the step to fail.

🔗 https://tools.slack.dev/slack-github-action/additional-configurations#exiting-with-errors

[zimeg]

Adding the following option might surface these errors, and I'm now wondering if we should include this in all examples?

  - name: Attempt to without a token
    uses: slackapi/slack-github-action@v2.1.0
    with:
+     errors: true
      method: chat.postMessage
      token: "xoxb-unknown"
      payload: |
        text: "palindrome"