bug: fix deprecation warnings by bumping python minimum version#10
Merged
WilliamBergamin merged 5 commits intomainfrom Jan 24, 2024
Merged
bug: fix deprecation warnings by bumping python minimum version#10WilliamBergamin merged 5 commits intomainfrom
WilliamBergamin merged 5 commits intomainfrom
Conversation
seratch
approved these changes
Jan 24, 2024
Contributor
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
Thanks, LGTM. Left an unrelated comment on PyPy support.
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", |
Contributor
There was a problem hiding this comment.
"Programming Language :: Python :: Implementation :: PyPy"
Have we verified if this module works with PyPy? If we haven't , running tests like below should be a good way to check it out: https://github.com/slackapi/python-slack-sdk/blob/v3.26.2/.github/workflows/ci-build.yml#L25
If it does not work for some reason, I believe it's fine to remove PyPy from this metadata as the need for it should be minor.
Contributor
Author
There was a problem hiding this comment.
Good catch, all tests pass with pypy3.10 💯 add this to the ci build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this PR is to bump the minimum version of python to 3.9 and subsequently removed all deprecated packages that may have been used to satisfy older versions of python
Testing
scripts/build_pypi_package.shSpecial notes
Are there any other changes from 3.6 to 3.9 that are worth including here?
Requirements
./scripts/install_and_run_tests.shafter making the changes.