Merged
Conversation
- Add Env field to CommandReq struct for passing environment variables
through the RPC protocol
- Update Pty.Start to accept and merge client environment variables
with host environment (client vars override host vars)
- Capture essential env vars (TERM, COLORTERM, LANG, LC_ALL) from
CLI client and pass to remote PTY
- Default to TERM=xterm-256color if not set by client
- Set TERM=xterm-256color for UI sessions (web terminal)
- Remove debug log.Print("xxxx") in ui.go
- Update dependencies
This fixes terminal rendering issues caused by missing TERM variable
when connecting to remote PTY sessions.
UI improvements: - Add terminal resize support: client sends resize events to server, server updates PTY dimensions via SetPtySize - Add automatic reconnection with up to 5 retry attempts - Add visual connection status messages (connecting, connected, disconnected, reconnecting) - Improve terminal styling with VS Code-like dark theme - Add cursor blinking and better font settings - Debounce resize events to prevent excessive updates - Fix duplicate HTML closing tags at end of term.html Server improvements: - Add wsReader that intercepts JSON resize messages from WebSocket - Parse resize messages with type="resize", cols, rows fields - Forward regular terminal data to PTY unchanged - Add bounds checking for terminal dimensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes terminal rendering issues caused by missing TERM variable when connecting to remote PTY sessions.