fix dynamic containers rm function after v4 migration#964
Merged
Conversation
badrogger
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for discovering and removing Docker containers related to "skaled" and "IMA" services, expanding support for both new and legacy container name prefixes. It also adds comprehensive tests to ensure both naming conventions are handled correctly.
Docker container discovery and removal improvements:
get_all_skaled_containersandget_all_ima_containersindocker_utils.pyto return containers matching both the new (sk_*) and legacy (skale_*) name prefixes, ensuring compatibility with containers created under either convention.Testing enhancements:
docker_utils_test.pyforget_all_skaled_containersandget_all_ima_containersto verify that both new and legacy prefixes are detected, using mocked Docker clients and containers. [1] [2]