Skip to content

fix dynamic containers rm function after v4 migration#964

Merged
dmytrotkk merged 1 commit intodevelopfrom
fix-migration-from-v4
Mar 3, 2026
Merged

fix dynamic containers rm function after v4 migration#964
dmytrotkk merged 1 commit intodevelopfrom
fix-migration-from-v4

Conversation

@dmytrotkk
Copy link
Collaborator

This pull request updates the logic for discovering and removing Docker containers related to "skaled" and "IMA" services, expanding support for both new and legacy container name prefixes. It also adds comprehensive tests to ensure both naming conventions are handled correctly.

Docker container discovery and removal improvements:

  • Updated get_all_skaled_containers and get_all_ima_containers in docker_utils.py to return containers matching both the new (sk_*) and legacy (skale_*) name prefixes, ensuring compatibility with containers created under either convention.
  • Renamed related functions and log messages from "schain" to "skaled" for clarity and consistency.

Testing enhancements:

  • Added tests in docker_utils_test.py for get_all_skaled_containers and get_all_ima_containers to verify that both new and legacy prefixes are detected, using mocked Docker clients and containers. [1] [2]

@dmytrotkk dmytrotkk self-assigned this Mar 3, 2026
@dmytrotkk dmytrotkk linked an issue Mar 3, 2026 that may be closed by this pull request
@dmytrotkk dmytrotkk merged commit ae17256 into develop Mar 3, 2026
2 of 3 checks passed
@dmytrotkk dmytrotkk deleted the fix-migration-from-v4 branch March 3, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skaled and IMA containers are not being cleaned up during update

2 participants