Filter nested properties based on metadata#130
Merged
dmosorast merged 10 commits intosinger-io:masterfrom Oct 27, 2020
Merged
Conversation
Update filter_data_by_metadata function to allow filtering of nested fields - e.g. if property `address` has selected set to True, but property `address.street` has selected set to False, only the street would be excluded. Processes data recursively.
make formatting a little clearer
Fix array type breadcrumb name
breadcrumb path documentation
change based on tests - must remove field from data object, not just set value to None.
line lenght :)
…into bug/filter-record
judahrand
changed the title
Contributor
Author
|
Seems to be Pylint failing which isn't a result of this PR but I'll fix the issues. |
dmosorast
approved these changes
Oct 27, 2020
Contributor
dmosorast
left a comment
dmosorast
left a comment
There was a problem hiding this comment.
Looks great, good tests, and nice formatting change 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This is an extension of PR #94. I have added two tests, one which tests that nested fields in an object are filtered and one which tests that nested fields in an array of objects are filtered.
Manual QA steps
Risks
Rollback steps