Support "post sim calibration" in noise models#13
Merged
Conversation
…cal, add calibrate and calibrations_subproduct kwargs to get_sim and change seed kwarg default to 'auto'. utils: remove get_mul_fact. io: add calibrations_subproduct and change meaning of calibrated
Collaborator
Author
|
Tracks simonsobs/sofind#19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simulations can now apply calibration factors on-the-fly using calibration products in
sofind. There are 4 cases:calibrate='auto'toget_sim(default) AND noise model config hascalibrated: true: the calibrations and polarization efficiencies in the noise model configcalibrations_subproductwill be applied to eachsuper_qidin the simcalibrate='auto'toget_sim(default) AND noise model config hascalibrated: false: the sim is uncalibratedcalibrate=True: the calibrations subproduct passed toget_simby thecalibrations_subproductkwarg is used, regardless of what is in the noise model configcalibrate=False: the sim is uncalibrated, regardless of what is in the noise model configNote: in all cases, sims written to disk are uncalibrated. Sims loaded from disk therefore behave just like sims generated on-the-fly: after loading (or generation), the above calibration behavior is applied.