Add tests for reaction-based PR merge handler#18
Open
rossnelson wants to merge 3 commits intomainfrom
Open
Conversation
Replace the deploy command's auto-cleanup with a reaction-driven workflow: - New reaction handler listens for :approved: on root thread messages - Merges the associated PR, adds :merged: reaction, then cleans up - Deploy command now only creates the PR (workspace stays alive for merge) - Add TypeScript to runtime Docker image
Tests cover: ignoring non-approved reactions, missing sessions, missing PR mappings, missing workspaces, already-merged/closed PRs, happy path merge flow, and merge failure error handling.
- Update expected args: --allowedTools * → --model sonnet - Save/restore env vars (CLAUDE_MODEL, CLAUDE_CODE_OAUTH_TOKEN) so tests hit the intended code paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:approved:→ merge →:merged:reaction handler introduced in Add reaction-based PR merge flow #17Test plan
npx vitest run src/bot/events/__tests__/reaction.test.ts— 11/11 passing