TSA verification #44
Merged
TSA verification #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
force-pushed
the
segiddins/tsa-verification
branch
from
f66f38f to
a7ce3ab
Compare
woodruffw
reviewed
Jun 27, 2024
| rescue OpenSSL::Timestamp::TimestampError => _e | ||
| # raise OpenSSL::Timestamp::TimestampError, "#{e} for #{chain.map(&:to_text).join("\n")}\n#{debug}" | ||
| true | ||
| resp.verify(req, store, chain) && |
Member
There was a problem hiding this comment.
Looks right to me! At least, from what I know of OpenSSL's TSR/TSA APIs.
woodruffw
approved these changes
Jun 27, 2024
Member
Author
yet |
Depends on ruby/openssl#770 Signed-off-by: Samuel Giddins <[email protected]>
segiddins
force-pushed
the
segiddins/tsa-verification
branch
from
a7ce3ab to
f440cea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ruby/openssl#770