create_resource: Issue when folder_id is set and not all users keys are imported.#25
Open
danielfl wants to merge 1 commit intoshubhamdipt:masterfrom
Open
create_resource: Issue when folder_id is set and not all users keys are imported.#25danielfl wants to merge 1 commit intoshubhamdipt:masterfrom
danielfl wants to merge 1 commit intoshubhamdipt:masterfrom
Conversation
Without importing GPG key, secret sharing to a folder will fail.
danielfl
changed the title
Author
|
Looking closer, I see this can be achieved by "import_public_keys()", however, I don't want to import/trust hundreds of keys to my keystore, only keys from those I have contact with. But feel free to reject/close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without importing all users GPG keys, the secret sharing to a folder will fail.
On the share_payload you will receive an error saying the PGP message is empty:
{'user_id': 'XXXXXXXXXXXX', 'data': ''}]}
ERROR:root:{"header":{"id":"XXXX-0bdc-43f0-8d16-XX","status":"error","servertime":1708009984,"action":"XXXX-9d43-5749-a5fe-XX","message":"Could not validate resource data.","url":"/share/resource/XX-7d37-4b13-a86c-XX.json","code":400},"body":{"secrets":{"1":{"data":{"_empty":"The message should not be empty."}}}}