fix: include app_id in patch storage path#89
Merged
bryanoltman merged 6 commits intoshorebird/devfrom Jun 17, 2025
Merged
Conversation
eseidel
reviewed
Jun 16, 2025
eseidel
approved these changes
Jun 16, 2025
felangel
pushed a commit
that referenced
this pull request
Jun 26, 2025
* fix: include app_id in patch storage path * add unit test * format * rename * fix gn * fix tests
felangel
pushed a commit
that referenced
this pull request
Jul 9, 2025
* fix: include app_id in patch storage path * add unit test * format * rename * fix gn * fix tests
felangel
pushed a commit
that referenced
this pull request
Jul 17, 2025
* fix: include app_id in patch storage path * add unit test * format * rename * fix gn * fix tests
felangel
pushed a commit
that referenced
this pull request
Jul 25, 2025
* fix: include app_id in patch storage path * add unit test * format * rename * fix gn * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include app_id in the patch cache path to avoid collisions. This is only necessary on desktop platforms, as mobile apps are sandboxed.
Fixes shorebirdtech/shorebird#3174