fix: use of FlutterEngineGroup breaks patching#101
Merged
eseidel merged 2 commits intoshorebird/devfrom Jan 23, 2026
Merged
Conversation
eseidel
added a commit
that referenced
this pull request
Jan 26, 2026
* es/report_start_fix * fix: second callsite
bdero
pushed a commit
that referenced
this pull request
Feb 3, 2026
* es/report_start_fix * fix: second callsite
bdero
pushed a commit
that referenced
this pull request
Feb 11, 2026
* es/report_start_fix * fix: second callsite
bdero
pushed a commit
that referenced
this pull request
Feb 13, 2026
* es/report_start_fix * fix: second callsite
bdero
pushed a commit
that referenced
this pull request
Feb 21, 2026
* es/report_start_fix * fix: second callsite
bdero
pushed a commit
that referenced
this pull request
Mar 2, 2026
* es/report_start_fix * fix: second callsite
bdero
pushed a commit
that referenced
this pull request
Mar 5, 2026
* es/report_start_fix * fix: second callsite
bdero
pushed a commit
that referenced
this pull request
Mar 10, 2026
* es/report_start_fix * fix: second callsite
bdero
pushed a commit
that referenced
this pull request
Mar 24, 2026
* es/report_start_fix * fix: second callsite
bdero
pushed a commit
that referenced
this pull request
Mar 27, 2026
* es/report_start_fix * fix: second callsite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were calling shorebird_report_launch_start too early, which meant that if you started a FlutterEngine without ever creating a shell, we would never actually load the dart patch and thus never report succesful load. Thus mark the current patch bad even though we'd never loaded it.