fix: source map generation (following #150)#161
Merged
shellscape merged 2 commits intoshellscape:masterfrom Jul 12, 2021
anthochamp:fix-source-map
Merged
fix: source map generation (following #150)#161shellscape merged 2 commits intoshellscape:masterfrom anthochamp:fix-source-map
shellscape merged 2 commits intoshellscape:masterfrom
anthochamp:fix-source-map
Conversation
added 2 commits
July 7, 2021 12:01
shellscape
reviewed
Jul 9, 2021
Owner
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue #
Sourcemap generation when used with postcss-less doesnt work (probably since the update to postcss 8).
Issues is related to AST locations. It translates into silent errors (wrong source mapping) in most cases, except when used to transpile inline comments ending with a ";" (as seen in the added test). In that last case transpilation throws an error.
Please check one:
This PR: