Correctly calculate last parens in ruleset as mixin param#132
Merged
shellscape merged 1 commit intoshellscape:masterfrom Dec 28, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
- Coverage 96.49% 96.47% -0.02%
==========================================
Files 8 8
Lines 228 227 -1
==========================================
- Hits 220 219 -1
Misses 8 8
Continue to review full report at Codecov.
|
shellscape
approved these changes
Dec 28, 2018
Owner
shellscape
left a comment
There was a problem hiding this comment.
Thank you for contributing a fix!
@jwilsson this looks good to me. please give this a look
jwilsson
approved these changes
Dec 28, 2018
Collaborator
jwilsson
left a comment
There was a problem hiding this comment.
Looks good to me too.
Thanks for the fix!
|
Hi guys! Could you please release this fix? Thanks a lot in advance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue # if any, does this resolve?
#128
Please check one:
This PR:
The following code found in
lib/LessParser.js:95always returns the first closing parenthesis rather than the last, as indicated by the variable name.This breaks the parsing when there are multiple closing parenthesis in the list of tokens.