Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 95.74% 96.09% +0.35%
==========================================
Files 8 8
Lines 188 205 +17
==========================================
+ Hits 180 197 +17
Misses 8 8
Continue to review full report at Codecov.
|
jwilsson
approved these changes
Nov 14, 2018
Collaborator
jwilsson
left a comment
There was a problem hiding this comment.
I like this idea, putting everything into params, better too. I'd argue that everything are parameters and parsing that should be easy enough if someone wants to parse it further.
Code LGTM too.
Owner
Author
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue # if any, does this resolve?
Please check one:
This PR:
This PR fixes #121 by adding relatively naive support for the new
eachfunction in LESS.eachis relatively unique, as it's the only function used at the root level, outside of a ruleset. While this change doesn't do anything special with the params, it allows the parser to continue on without throwing an error.The result is an
AtRulewith afunction: trueproperty, andparamsproperty which contains everything between the first and last, open and closed parenthesis.In the future we might examine how to parse and present the params for
eachin the node.